Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translations in 3.7.0, always shown in English #2520

Open
0q1627 opened this issue Apr 9, 2024 · 2 comments
Open

Missing translations in 3.7.0, always shown in English #2520

0q1627 opened this issue Apr 9, 2024 · 2 comments

Comments

@0q1627
Copy link

0q1627 commented Apr 9, 2024

Environment:

  • CTFd Version/Commit: 3.7.0
  • Operating System: any
  • Web Browser and Version: Firefox 115

What happened?
When playing a challenge in a language different than English, with the core-beta theme, some text is always shown in English.

What did you expect to happen?
Expected to be translated like everything else.

How to reproduce your issue
Set your language to non-English. Participate in a challenge and pay attention to these messages that appear when submitting an answer as they are always shown in English:

  • Correct
  • Incorrect
  • You already solved this
  • You have _ tries remaining
  • Incorrect. You have _ try remaining
  • Scores are currently hidden

I think they are missing in all translations. I checked Italian, Spanish, French, Slovenski, German.

Any associated stack traces or error logs
N/A

@ColdHeat
Copy link
Member

ColdHeat commented Apr 9, 2024

Is this onlatest commit or on the specific release? Are you able to register on Crowdin to maybe translate these strings? I'm not sure if that's the cause or not. https://crowdin.com/project/CTFd

@0q1627
Copy link
Author

0q1627 commented Apr 10, 2024

Can't say for sure about old versions as I am a new user, but I feel it is not only in the latest commit.

The six strings I found and posted above are not present in messages.po files according to github search. And the (core-beta) template does not call their translation either, as far as I understand how localization works.

This is an example of a string being translated in CTFd/themes/core-beta/templates/components/navbar.html:
{% trans %}Scoreboard{% endtrans %}

I cannot find a call to "{% trans %}" for the strings I mentioned when opening the issue.

Note: there might be more strings that miss the translation that I haven't met when testing a CTF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants