Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite FilterbankProcessor #248

Open
superbock opened this issue Feb 13, 2017 · 2 comments · May be fixed by #405
Open

Rewrite FilterbankProcessor #248

superbock opened this issue Feb 13, 2017 · 2 comments · May be fixed by #405

Comments

@superbock
Copy link
Collaborator

FilterbankProcessor should hold all parameters to filter a Spectrogram (or the like). When processing data, it should create a Filterbank upon being called for the first time and cache it for consecutive calls (like a buffer).
@superbock
Copy link
Collaborator Author

Maybe, we should drop the combined spectrogram processors (i.e. FilteredSpectrogramProcessor, LogarithmicSpectrogramProcessor and LogarithmicFilteredSpectrogramProcessor) altogether? Not sure about the data classes though...

@superbock superbock mentioned this issue Feb 13, 2017
Merged
17 tasks
@superbock superbock changed the title Rewrite FilterbankProcessor Rewrite FilterbankProcessor Feb 13, 2017
@fdlm
Copy link
Contributor

fdlm commented Feb 20, 2017

This would break backwards compatibility. If we split this up, we should redefine the dropped processors as sequential processors containing pipelines reproducing the old behaviour, so they can be still used.

Regarding the data classes, I think they're still useful shortcuts.

Or, put differently, what do we gain if we drop the combined processors and the data classes?

This was referenced Dec 29, 2018
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] refactor filtering and scaling of spectrograms CPJKU/madmom
2 participants
@fdlm @superbock