Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uServices error handling? #2

Open
erikbosch opened this issue Oct 24, 2023 · 1 comment
Open

uServices error handling? #2

erikbosch opened this issue Oct 24, 2023 · 1 comment

Comments

@erikbosch
Copy link

Out of curiosity, is there a "design pattern" documentation for uServices? I notice that all RPCs return a message containing google.rpc.Status. But isn't google.rpc.Status implicitly included anyway, i.e. a server can return for instance INVALID_ARGUMENT (like in this example) even if there is no explicit google.rpc.Status field in the return message.

Or is it so that as part of uServices/uProtocol that an explicit google.rpc.Status as part of the return message always is required, or at least recommended?

service Engine {
...

  // Request to reset an engine component's life to 100%. After a reset, the
  // remaining life will go back to 100% and the health state of that component
  // will go back to the OK state.
  rpc ResetHealth(ResetHealthRequest) returns (ResetHealthResponse) {
    option (method_id) = 1;
  }
}

...

// Response to reset health request
message ResetHealthResponse {
  // Rpc return status
  google.rpc.Status status = 1;
}
@stevenhartley
Copy link
Contributor

stevenhartley commented Oct 24, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants