Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search speed. #167

Closed
SimonPreisinger opened this issue Jan 14, 2021 · 6 comments
Closed

Improve search speed. #167

SimonPreisinger opened this issue Jan 14, 2021 · 6 comments
Assignees

Comments

@SimonPreisinger
Copy link

Currently the search is slow with use of a lot of traces and could be improved.
My suggestion is to improve the search speed by using several threads instead of one.
Should be possible with Qt Concurrent
I know there are plugins but they are complicated to install.

Later this can be done for applying a filter also.

@alexmucde
Copy link
Collaborator

We already made some multithreading tests in the past with, but we were not very succesful. I think the bottleneck is the file access to HDD/SSD. But perhaps someone can give it a try again.

@SimonPreisinger
Copy link
Author

I want to try it pls give me access to create a pull request

@alexmucde
Copy link
Collaborator

@SimonPreisinger You can create a clone in your own Github Account, create the change there and then request a Pull Request. You do not need Write access to the DLT Viewer repository to create branches.

@svlad-90
Copy link
Contributor

Hi @SimonPreisinger, you can avoid inventing a bicycle - try out the DLT-Message-Analyzer plugin: https://github.com/svlad-90/DLT-Message-Analyzer. It covers your need as it creates the in-RAM-cache of all the messages within the file ( or the ones which are coming in from the opened connection to a target device ) and searches within the cache. The size of the cache is adjustable. The search is multi-threaded with the possibility to select the number of the threads to be used. The speed of the search is in average ~10 times faster.

P.S. I'm not trying to convince you to not extend the core functionality. Just telling, that the way exist, which might save you some efforts ))

@alexmucde
Copy link
Collaborator

Any progress on this topic?

@alexmucde
Copy link
Collaborator

As there is no progress i will close this issue. New issue exists to use a search database engine for faster search in milliseconds. See #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
COVESA DLT Viewer
  
Awaiting triage
Development

No branches or pull requests

3 participants