Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual masking - User error or it's not working? #604

Closed
7 tasks
Rooper-ai opened this issue Apr 12, 2024 · 11 comments
Closed
7 tasks

Manual masking - User error or it's not working? #604

Rooper-ai opened this issue Apr 12, 2024 · 11 comments
Labels
bug Something isn't working

Comments

@Rooper-ai
Copy link

Describe the bug

Perhaps I am not understand how manual masking should work or the steps to get it to work, but had no luck so far. I have read the 3.6.0 release note comments here: (#512) but its not helping

To Reproduce
Steps to reproduce the behavior:

1.Add input face (woman's face)
2.Add target face (man's face)
3. 'Use face from this frame' for target face
4. Go to Advanced Masking dropdown
5. hit Toggle manual masking button
6. Select Draw button in manual mask image
7. Draw mask over man's left eye and eyebrow
8. Hit Start button

At this point I would expect to see the Final image with a man's left eye (masked) and a woman's right eye (not masked)

But I'm getting two female eyes with no masking (???)

Details
What OS are you using?

  • [ Yes] Linux
  • Linux in WSL
  • Windows
  • Mac

Are you using a GPU?

  • No. CPU FTW
  • [Yes ] NVIDIA
  • AMD
  • Intel
  • Mac

Which version of roop unleashed are you using?

3.6.7

Screenshots
If applicable, add screenshots to help explain your problem.

@C0untFloyd C0untFloyd added the bug Something isn't working label Apr 14, 2024
@C0untFloyd
Copy link
Owner

You are right, I tested myself and it's not working. It IS working if you're using it with face swap frames enabled in the preview image. I remember thinking that since this is images only, nobody would need this in the batch processing. Anyway, I will integrate this into real processing too.

@iemtejas
Copy link

Manual masking is not working on single images

@C0untFloyd
Copy link
Owner

It IS working if you're using it with face swap frames enabled in the preview image.

@Rooper-ai
Copy link
Author

These steps work:

  1. Add input face (woman's face)
  2. Add target face (man's face)
  3. 'Use face from this frame' for target face
  4. Go to Advanced Masking dropdown
  5. hit Toggle manual masking button
  6. Select Draw button in manual mask image
  7. Draw mask over man's left eye and eyebrow
  8. Hit Face swap frames tick box (below Preview Image) [BTW looks greyed out on my browser]

..processed manual masked image then appears in the Preview Image area (works)

However this isn't the workflow I would have expected. I would expect to hit the Start button and see the processed manual mask image in the Final image area (doesn't work)

For example does post-processing work in preview, UI would suggest not, even if it does.

Also thanks for all your efforts on this fork. It's appreciated

@iemtejas
Copy link

It IS working if you're using it with face swap frames enabled in the preview image.

It's not working for me. I've tried these steps, but it's still not just changing the masked area, but the whole face. Unfortunately, it's not working for me. Could you please add a button to it, similar to text masking? This way, we can select and mask the area we want to swap, and it'll only swap the masked area. This method would be the best, similar to XEG masking

@C0untFloyd
Copy link
Owner

Could you please add a button to it, similar to text masking? This way, we can select and mask the area we want to swap, and it'll only swap the masked area. This method would be the best, similar to XEG masking

But it is exactly like that?!? Click on toggle manual masking, draw the mask onto the areas YOU WANT TO KEEP, hit refresh and be surprised.

@iemtejas
Copy link

iemtejas commented Apr 16, 2024 via email

@C0untFloyd
Copy link
Owner

For example does post-processing work in preview, UI would suggest not, even if it does.

Preview does EVERYTHING the regular processing does, except for the batch processing. I often don't even click on start but save the image right away from the preview area. Btw. to see the preview image in all its glory you can also do a right click and "Open in new Tab".

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 22, 2024
@Sam929228
Copy link

Hello i am new to this awsome software can u guys teel me how i can extract or delete unwanted frames from my videos please reply soon using roop unleashed v4 and i have rtx3070 ti 8gb laptop gpu how any threads should in keep it at far faster rendering

@github-actions github-actions bot removed the Stale label May 27, 2024
@C0untFloyd
Copy link
Owner

Hello i am new to this awsome software can u guys teel me how i can extract or delete unwanted frames from my videos please reply soon using roop unleashed v4 and i have rtx3070 ti 8gb laptop gpu how any threads should in keep it at far faster rendering

https://github.com/C0untFloyd/roop-unleashed/wiki/Face-Swap-Tab
https://github.com/C0untFloyd/roop-unleashed/wiki/FAQ#why-is-my-graphics-card-gpu-not--hardly-being-utilized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants