Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git rebase diagram correct? #34

Open
Bascy opened this issue Oct 23, 2023 · 1 comment
Open

git rebase diagram correct? #34

Bascy opened this issue Oct 23, 2023 · 1 comment

Comments

@Bascy
Copy link

Bascy commented Oct 23, 2023 •
edited

I think the git rebase diagram is not correct:

After rebasing the feature branch on master, the master branch does not change (still pointing to D), and feature branch is still pointing to G.

Commit E is now based on D in stead of B which is already correct in the diagram
@macie
Copy link

macie commented Oct 24, 2023

@Bascy you are right. Rebase changes "base commit" of feature branch, without merging feature branch to main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bascy @macie