Inconsistency between the plist and folder names

[yemartin]

Now by default, the folder is called Licenses, but the plist is Acknowledgements.plist. It would be much nicer for consistency if these would be called the same.

Doesn't this look better?

[yvbeek]

Good point!

The section in Settings is called “Acknowledgements”, because it is used to acknowledge the fact that specific libraries are used in your app. It does so by providing a list of Licenses, one License for each library.

I agree it would be better to keep the folder name the same as the plist. But perhaps it would be better to call them both Acknowledgements?

I’m also thinking that the script should add a small description to the plist like:

“Portions of this Software may utilize the following copyrighted material, the use of which is hereby acknowledged:”

Looking forward to hear your thoughts on the above.

[yemartin]

Sure, Acknowledgements for both sounds good too.

I really like your idea of adding a description. Without it, the child panel is a bit dry at the moment...

It would be best for it to be customizable and i18n friendly. I am not too sure of this, but maybe you could add a Strings Filename entry to Acknowledgements.plist, with a value of Acknowledgements of course, for consistency 😉 . Then creating en.lproj/Acknowledgements.strings should allow to easily customize / i18nize that description.

[yvbeek]

@yemartin A minute ago I pushed a new commit, with quite a few changes to the inner workings of AckAck. The new version will continue to use the Licenses folder if it exists (so that it doesn't break with earlier versions, but if that folder isn't found it will call the folder Acknowledgements). I didn't have time yet to add the description feature.

@palmtrae I saw your fork of AckAck, this new version is now also using the ArgumentParser and has multi input folder support. I've added a few more features that you might like.

---

I've tested this version with Python 2.7.10 and 3.7.2.

If you guys encounter any issues with this version please let me know.
I'll soon release it as 4.0.

[palmtrae]

Wow that sounds fantastic! I was actually going to open an issue about the fork I made to discuss some of the changes I made. But deadlines and other responsibilities has prevented me from doing that.

Looking forward to the 4.0 release, this script has saved me and my coworkers a bunch of time.