Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open for PR / contributions? #7

Open
peterlundberg opened this issue Oct 15, 2021 · 1 comment
Open

Open for PR / contributions? #7

peterlundberg opened this issue Oct 15, 2021 · 1 comment

Comments

@peterlundberg
Copy link

Found this library when needing this in a real world situation. Great work and (relatively) well used linked in npm etc.

When benchmarking with our use case this performed well and better than other packages on npm. Did find a few things that can be improved and allows even faster execution with a modern v8.

However, support for ignoreCase and to emit/output more than just the keyword was missing so this was not directly useable.

Would you be open to contributions or a discussion on how to add this to this library so we can contribute back?

@amosbastian
Copy link

@peterlundberg did you end up implementing these improvements elsewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants