Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Scratch-Based Docker Images #46

Open
BrenekH opened this issue Mar 27, 2021 · 1 comment
Open

Build Scratch-Based Docker Images #46

BrenekH opened this issue Mar 27, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers low priority

Comments

@BrenekH
Copy link
Owner

BrenekH commented Mar 27, 2021

It would be advantageous to build a runner docker image that doesn't rely on a package manager to download FFmpeg.

A possible source of these binaries could be https://johnvansickle.com/ffmpeg/, but the licensing needs to be looked at. I assume it'd be fine to download using curl or wget and put into a docker image, but I'm not 100% on that just yet.

@BrenekH BrenekH added the enhancement New feature or request label Mar 27, 2021
@BrenekH BrenekH added good first issue Good for newcomers and removed Hacktoberfest labels Nov 12, 2021
@BrenekH BrenekH changed the title Static FFmpeg builds Build Scratch-Based Docker Images Dec 7, 2021
@BrenekH
Copy link
Owner Author

BrenekH commented Dec 7, 2021

Currently, the runner-scratch-image branch contains the changes to the Dockerfile and GitHub Actions workflow that make a scratch image possible. I have confirmed that they work as intended (including timezone related items such as logging).

Even though everything is operating correctly there are still questions that need to be answered, the foremost being, is it legal to distribute FFmpeg in this way? Encodarr is licensed under MPL 2.0, but FFmpeg is either LGPL or GPL which may pose a problem when packaging everything together into a Docker image. The other issue is how will hardware acceleration be accomplished because it appears that John Van Sickle's builds don't support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers low priority
Projects
None yet
Development

No branches or pull requests

1 participant