Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo-binstall for cli #455

Open
listepo opened this issue May 9, 2024 · 9 comments
Open

Use cargo-binstall for cli #455

listepo opened this issue May 9, 2024 · 9 comments

Comments

@listepo
Copy link

listepo commented May 9, 2024

It would be great to make a prisma-client-rust-cli package via install cargo-binstall

@Brendonovich
Copy link
Owner

From what I understand cargo-binstall and tools like it require publishing to crates.io, which I won't be doing (#76).
If it can support git dependencies then I'll consider it.

@listepo
Copy link
Author

listepo commented May 16, 2024

searching the linked repository for matching releases and artifacts
I thought it was loading artifacts from Github. But I could be wrong

@listepo
Copy link
Author

listepo commented May 16, 2024

Maybe @NobodyXu can help

@NobodyXu
Copy link

NobodyXu commented May 16, 2024

Yes, cargo-binstall has --git support, as long as your repository have a Cargo.toml with reppsitory and the version ser, its automatic detection would work

@NobodyXu
Copy link

NobodyXu commented May 16, 2024

Checking the Cargo.toml for cli, it seems to be missing repository, and its version doesn't match the one is gh release, so if that's updated, amd have pre-built binaries put on github release, it should work.

@NobodyXu
Copy link

Checkout our doc for how cargo-binstall automatically discovers gh release artifacts https://github.com/cargo-bins/cargo-binstall/blob/main/SUPPORT.md#defaults

@listepo
Copy link
Author

listepo commented May 16, 2024

@NobodyXu thanks, @Brendonovich is this information useful to you?

@listepo
Copy link
Author

listepo commented May 17, 2024

@NobodyXu could you help with this task? since you have an understanding of what needs to be done

@NobodyXu
Copy link

Basically, you need to:

  • add repository for Cargo.toml of the cli crate
  • update the version of the for Cargo.toml of the cli crate to match release on github
  • update release pipeline to include pre-built artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants