Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing password for default [email protected] user before first start #4513

Closed
1 task done
e-g1gor opened this issue Sep 4, 2023 · 2 comments
Closed
1 task done

Comments

@e-g1gor
Copy link

e-g1gor commented Sep 4, 2023

Describe the feature you'd like

Initial password for default admin should be configurable somehow, maybe via .env file, like

DEFAULT_ADMIN_PASSWORD=xxx

Describe the benefits this would bring to existing BookStack users

There is default migration, that creates admin user with easily brutable credentials.
It allows to easily bruteforce admin access to newly deployed services - for as long as someone do not change password manually.

If this service is being deployed to domain that attracted attention of hackers - they may perform atack immediately, before default password will be changed.

Can the goal of this request already be achieved via other means?

By tweaking original migration -

Have you searched for an existing open/closed issue?

  • I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?

Not using yet, just scoping

Additional context

No response

@ssddanbrown
Copy link
Member

Thanks for the request @e-g1gor.

Somewhat related to #3946 and #3947.
As per my comment in #3947, I'd ideally like to change how the initial account is created, but I just need to ensure it works for all existing use-cases & installation options without too much pain, and requires some coordination across hosting options and documentation.

I may start to think about intended route on for the current maintenance release cycle.

From my view I'm not too worried about the "bruteforce" scenario here (although no need to bruteforce where it's using a single default option), I think that's rare and can be mitigated via following our guidance, networking and other controls if that really is a concern, my main concern is just with folks not changing the default credentials.

@ssddanbrown
Copy link
Member

I've now opened #4575 to put forward a multi-stage plan in changing the default admin account handling, with an aim to provide a smooth transition and work with downstream setup/install/guide providers.
I'll therefore close this in favour of centralising things to that issue.

Thanks again @e-g1gor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants