Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSBT-Scan successful, signed and immediately sent to network without user confirmation #6557

Closed
silkroadnomad opened this issue May 15, 2024 · 2 comments

Comments

@silkroadnomad
Copy link

silkroadnomad commented May 15, 2024

I recently experimented with scanning PSBTs. I prepared a transaction on a website, which produced a QR code.

Upon scanning the QR code, the window unexpectedly closed without any feedback. I repeated the scan two or three more times, each time with the same result. Later, I discovered that my PSBT was scanned, signed, and successfully broadcasted to the network three times. While I was pleased with the successful broadcasting, I believe the process can be improved. Here are my suggestions:

  1. Transaction Confirmation: Users should confirm the transaction before it is signed and broadcasted.
  2. Transaction Details Screen: Users should see a screen displaying the amount of BTC being sent from their wallet and the outputs.
  3. MultiSig PSBT Handling: Scanning a MultiSig PSBT should result in a signed hex with the option to scan or save the signed hex for use with another device or MultiSig wallet (I didn't tested this yet)
  4. BBQR Integration: Implementing BBQR might be necessary for this functionality (see Issue #6311).
@Overtorment
Copy link
Member

thats weird. we support the whole flow of (co)signing ms transactions via psbts, there should be confirmations all steps of the way.

whats your uniqID (settings->about)? ill look it up on our crash reporting service

@silkroadnomad
Copy link
Author

I need to double check this. Until then I close the issue in order to reduce noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@silkroadnomad @Overtorment and others