Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit button doesn't work #3

Open
KyLeggiero opened this issue Oct 21, 2019 · 5 comments
Open

Edit button doesn't work #3

KyLeggiero opened this issue Oct 21, 2019 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@KyLeggiero
Copy link
Member

It seems to think BenLeggiero.blog is the best place to edit the current set of guidelines
@KyLeggiero KyLeggiero added bug Something isn't working good first issue Good for newcomers labels Oct 21, 2019
@KarlaChen
Copy link

Hi, @BenLeggiero . Can you tell me what you want? I think I can fix it.

@KyLeggiero
Copy link
Member Author

@KarlaChen thanks! There should be a line at the bottom of one the template files which links to my blog, whereas the links around it are generated with Liquid includes. That blog link should also be generated like them

@KarlaChen
Copy link

@BenLeggiero Do you mean Suggest An Edit button?

@KyLeggiero
Copy link
Member Author

@KarlaChen yep!

@KyLeggiero
Copy link
Member Author

Replacing the footer with this will probably solve the issue:

https://github.com/BlueHuskyStudios/Neon-Jekyll-Components/blob/production/Page-Info/footer-card.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KyLeggiero @KarlaChen