-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lodash sometimes loads and overwrites _, breaking various modules #142
Comments
Well wait now we broke the video hahaha
And I think @1wheel's fix is a race condition thing, so like 1 in 20 times the video works and nothing else does. (I shoulda grabbed the log that 1 time out of 20 but it basically just looked like before the fix...) |
I guess there's no way to exactly future-proof this when it's loading arbitrary ad code, but I feel like we should bite the bullet and do a big find-and-replace with a |
what about:
|
This usually but not always happens. Looks like a recent version of Lodash removed
contains
as an alias. Seems like sometimes Lodash loads and overwrites this version of Underscore. But I can't figure out how Lodash is even getting on the page lol.I can take more of a look later.
cc @aubergene @blacki <3
The text was updated successfully, but these errors were encountered: