-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various MuSig Improvements #155
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
API
msglen
argument to all function currently only taking anmsg32
.secp256k1_musig_partial_sign
interface. If true it would do a partial signature verification before returning (H/T @robot-dreams).ipre_sig64
argument ofmusig_adapt
andmusig_extract_adaptor
as secret (for constant-timeness test)Internal
musig_nonce_gen
currently rejectssession_id32=0
if there's noseckey
. This check could be stronger and reject weak entropy counters, for example in a endianness-independent way by checking that the middle 16-bytes are not all 0 (H/T @robot-dreams).ecmult_multi
) inpubkey_agg
when confidence in its implementation is higher.TODO
items: "use multiexp to compute-s*G + e*mu*pubkey + aggnonce[0] + b*aggnonce[1]
" and "Cache mu".The text was updated successfully, but these errors were encountered: