Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] smooth scrolling in sophisticated storage GUIs #215

Closed
Lucky-56 opened this issue May 20, 2024 · 2 comments
Closed

[Bug] smooth scrolling in sophisticated storage GUIs #215

Lucky-56 opened this issue May 20, 2024 · 2 comments
Labels
compatibility Compatibility with other libraries and modules minecraft Issues about Minecraft Mod instead of Core Framework no solution There's no way to fix this

Comments

@Lucky-56
Copy link

Lucky-56 commented May 20, 2024

Describe the bug
Smooth scrolling does not work with an sophisticated storage GUI (I have to scroll multiple times)

To Reproduce

  1. install Sophisticated Storage and Sophisticated Core
  2. either have GUI scale set to 4 or have a small screen
  3. place a double gold chest (in example) or higher tier
  4. open it
  5. place items inside
  6. scroll
  7. observe

Expected behavior
I did not expect anything just would've been nice to be able to blacklist some GUIs
"For the scrolling to work properly"

Screenshots
Idle:
2024-05-21_01 49 34

Scrolled once:
2024-05-21_01 49 38

Scrolled twice:
2024-05-21_01 49 41

Environment

  • Mod Version: 3.10.1.4
  • Forge Version: 47.2.32
  • Operating System: Win11
  • Graphics Card: GeForce RTX 3060
  • Other Mods:
    • Sophisticated Core 0.6.22.611
    • Sophisticated Storage 0.10.25.804
@Lucky-56
Copy link
Author

not the only issue but the most noticable one at a glance

@BloCamLimb
Copy link
Owner

That mod only updateSlotsYPosition on mouseScrolled and mouseDragged, it ignores scroll animation. The smooth scrolling is done by updating scrollDistance every frame, there's no callback method can be used to notify subclasses the scroll changes, so there's nothing we can do. To solve this issue, you need to ask the author of that mod to find the scrollDistance change during the render call.

https://github.com/P3pp3rF1y/SophisticatedCore/blob/f10ed7eaa2fc604ab283bcf8f637a79bf8503372/src/main/java/net/p3pp3rf1y/sophisticatedcore/client/gui/controls/InventoryScrollPanel.java#L90-L101

@BloCamLimb BloCamLimb added minecraft Issues about Minecraft Mod instead of Core Framework no solution There's no way to fix this compatibility Compatibility with other libraries and modules labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility with other libraries and modules minecraft Issues about Minecraft Mod instead of Core Framework no solution There's no way to fix this
Projects
None yet
Development

No branches or pull requests

2 participants