Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How do I use MaxToastCount? #252

Open
ShawnDoe opened this issue Feb 23, 2024 · 1 comment · May be fixed by #257
Open

How do I use MaxToastCount? #252

ShawnDoe opened this issue Feb 23, 2024 · 1 comment · May be fixed by #257
Labels
Feature Request Request to add a new feature Up For Grabs This issue is available to anyone that wants to help

Comments

@ShawnDoe
Copy link

There was a discussion added #186

"I have created my own toast component and I cannot really get it to work with the setting for maximum amount of toasts. If I use the standard methods for popping up toasts, it works. But not when I have created my own."

asking about this but it was never commented upon. I have the same issue. Can this be added to a new release?
@ShawnDoe ShawnDoe added Question Question about this project Triage Issue needs to be triaged labels Feb 23, 2024
@chrissainty chrissainty added Feature Request Request to add a new feature Up For Grabs This issue is available to anyone that wants to help and removed Question Question about this project Triage Issue needs to be triaged labels Mar 19, 2024
@chrissainty
Copy link
Member

chrissainty commented Mar 19, 2024 •
edited

Thanks for re-raising this @ShawnDoe. The issue is that this check

Toast/src/Blazored.Toast/BlazoredToasts.razor.cs

Line 114 in 21a1fa5

if (ToastList.Count < MaxToastCount)

and the resulting logic, doesn't exist in the ShowCustomToast method. This method would need to be updated to incorporate the same check. Happy to take a PR for this if you want to give it a go?

@Jimmys20 Jimmys20 linked a pull request May 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Request to add a new feature Up For Grabs This issue is available to anyone that wants to help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added MaxToastCount logic to ShowCustomToast Jimmys20/Toast
2 participants
@ShawnDoe @chrissainty