Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#112 - Removes duplicate method from SchemaUtils #142

Conversation

mbarlowvt
Copy link
Contributor

Fix included to resolve #112

@alpeshk
Copy link
Contributor

alpeshk commented Nov 13, 2017

@mbarlowvt , Thanks for your contribution. I agree with the changes. I have just one suggestion - To comply with our branching policy, can you please apply these changes to the engine_integrator branch? Once the changes pass our integration tests, they will be merged to the master branch.
We should have done a better job documenting the branching policy and I am on it. For now, it would be great if you can create this PR on the engine_integrator branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputOracleComponent.scala - Code Duplication
2 participants