Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputOracleComponent.scala - Code Duplication #112

Open
danyanos opened this issue Jun 27, 2017 · 0 comments
Open

InputOracleComponent.scala - Code Duplication #112

danyanos opened this issue Jun 27, 2017 · 0 comments
Labels
code quality Hydrograph Engine

Comments

@danyanos
Copy link
Contributor

InputOracleComponent.scala duplicates the compareSchema method found in hydrograph.engine.spark.components.utils.SchemaUtils. Refactor InputOracleComponent.scala to use the method from the SchemaUtils class.
@mbarlowvt mbarlowvt mentioned this issue Nov 7, 2017
Closed
alpeshk added a commit that referenced this issue Nov 14, 2017
@alpeshk
Merge pull request #148 from mbarlowvt/#112-InputOracleComponent.scal…
436baf0 
…a---Code-Duplication

Removes duplicate method from SchemaUtils and instantiates a case cla…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Hydrograph Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#112 - Removes duplicate method from SchemaUtils mbarlowvt/Hydrograph
1 participant
@danyanos