New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rare crash when unhooking #366

Open

kotae4 opened this issue May 20, 2022 · 0 comments

Labels

Member

kotae4 commented May 20, 2022

there is bug: https://github.com/BitCrackers/AmongUsMenu/blob/main/hooks/_hooks.cpp#L169
look at impl: https://github.com/BitCrackers/AmongUsMenu/blob/main/includes/detours/detours.cpp#L1937
if thread is within patched bytes when unhooking occurs then it'll crash. need to suspend every other thread and relocate instruction ptr if in trampoline.
the detours library does this but only if you call DetourUpdateThread for each other thread.

v0idp added the bug label

BitCrackers deleted a comment from 0verp0wer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment