Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polytect: an automatic clustering and labeling method for multi-color digital PCR data #3464

Open
10 tasks done
emmachenlingo opened this issue Jun 19, 2024 · 5 comments
Open
10 tasks done
Labels
1. awaiting moderation submitted and waiting clearance to access resources 3e. pending pre-review changes review has indicated blocking concern that needs attention

Comments

@emmachenlingo
Copy link

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Dear @emmachenlingo,

The package DESCRIPTION must contain valid biocViews.

The following are not valid biocViews terms and should be removed
dPCR
If you would like to request a term be added please email the
[email protected] mailing list and provide details on
why and where in the hierarchy you think it should be added.

Please fix your DESCRIPTION. See current biocViews
Please also remember to run BiocCheck::BiocCheck('new-package'=TRUE) on your package
before submitting a new issue. BiocCheck will look for other
Bioconductor package requirements.

@bioc-issue-bot
Copy link
Collaborator

Hi @emmachenlingo

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: Polytect
Title: An R package for digital data clustering
Version: 0.99.0
Authors@R: 
    person("Yao", "Chen", , "[email protected]", role = c("aut", "cre"),
 comment = c(ORCID = "0000-0001-8172-3996"))
Description: An automatic clustering and labeling method for multi-color digital PCR data to classify partitions into groups based on subpopulations generated by flowPeaks.
biocViews: dPCR, Clustering
License: MIT
Encoding: UTF-8
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.1
Depends: 
    R (>= 3.5.0)
Imports: 
    mvtnorm,
    sn,
    dplyr,
    flowPeaks,
    ggplot2,
    tidyverse,
    cowplot,
    mlrMBO,
    DiceKriging
Suggests: 
    testthat (>= 3.0.0),
    knitr,
    rmarkdown
VignetteBuilder: knitr

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Jun 19, 2024
@emmachenlingo
Copy link
Author

I have changed the biocViews to an existing one. thanks!

@lshep
Copy link
Contributor

lshep commented Jun 25, 2024

When I perform a R CMD build it is ERRORing. Please ensure R CMD build, R CMD check and BiocCheck are run without ERROR, Warning, or Notes

 R CMD build Polytect 
* checking for file 'Polytect/DESCRIPTION' ... OK
* preparing 'Polytect':
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
--- re-building ‘introduction.Rmd’ using rmarkdown

Quitting from lines 68-81 [flowpeaks and merge] (introduction.Rmd)
Error: processing vignette 'introduction.Rmd' failed with diagnostics:
could not find function "polytect_clust"
--- failed re-building ‘introduction.Rmd’

SUMMARY: processing the following file failed:
  ‘introduction.Rmd’

Error: Vignette re-building failed.
Execution halted

@lshep
Copy link
Contributor

lshep commented Jun 25, 2024

Also...

Could you provide a comparison to existing Bioconductor packages with similar
functionality in the vignette in addition to the generic comparison statement.

Please remove vignette/introduction.pdf and Polytect_manual.pdf. Vignette pdf
and man page compilations are generated automatically when R CMD build is run.

@lshep lshep added the 3e. pending pre-review changes review has indicated blocking concern that needs attention label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. awaiting moderation submitted and waiting clearance to access resources 3e. pending pre-review changes review has indicated blocking concern that needs attention
Projects
None yet
Development

No branches or pull requests

3 participants