Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEraster #3448

Open
10 tasks done
GohtaAihara opened this issue Jun 3, 2024 · 8 comments
Open
10 tasks done

SEraster #3448

GohtaAihara opened this issue Jun 3, 2024 · 8 comments
Assignees
Labels
2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place OK

Comments

@GohtaAihara
Copy link

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @GohtaAihara

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: SEraster
Type: Package
Title: Rasterization Preprocessing Framework for Scalable Spatial Omics Data Analysis
Version: 0.99.0
Authors@R: 
    c(person("Gohta", "Aihara", email = "[email protected]", 
    role = c("aut", "cre"), 
    comment = c(ORCID = "0000-0002-2492-9610")), 
    person("Mayling", "Chen", email = "[email protected]",
    role = c("aut"),
    comment = c(ORCID = "0009-0009-0961-6665")),
    person("Lyla", "Atta", email = "[email protected]", 
    role = c("aut"), 
    comment = c(ORCID = "0000-0002-6113-0082")), 
    person("Jean", "Fan", email = "[email protected]", 
    role = c("aut", "rev"), 
    comment = c(ORCID = "0000-0002-0212-5451")))
URL: https://github.com/JEFworks-Lab/SEraster
BugReports: https://github.com/JEFworks-Lab/SEraster/issues
Description: SEraster is a rasterization preprocessing framework that aggregates  
    cellular information into spatial pixels to reduce resource requirements for  
    spatial omics data analysis. SEraster reduces the number of spatial points in  
    spatial omics datasets for downstream analysis through a process of rasterization  
    where single cells’ gene expression or cell-type labels are aggregated into  
    equally sized pixels based on a user-defined resolution. SEraster is built on  
    an R/Bioconductor S4 class called SpatialExperiment. SEraster can be incorporated  
    with other packages to conduct downstream analyses for spatial omics datasets,  
    such as detecting spatially variable genes.
biocViews: 
    Software,
    Spatial,
    GeneExpression,
    Transcriptomics,
    SingleCell,
    Preprocessing
License: GPL-3
Encoding: UTF-8
LazyData: FALSE
Suggests: 
    CooccurrenceAffinity,
    nnSVG,
    testthat (>= 3.0.0),    
    knitr,
    rmarkdown
VignetteBuilder: knitr
Config/testthat/edition: 3
RoxygenNote: 7.3.1
Depends: 
    R (>= 4.3.0)
Imports: 
    BiocParallel,
    ggplot2,
    Matrix,
    methods,
    rearrr,
    sf,
    SpatialExperiment,
    SummarizedExperiment

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Jun 3, 2024
@lshep lshep added the pre-check passed pre-review performed and ready to be added to git label Jun 7, 2024
@bioc-issue-bot
Copy link
Collaborator

Your package has been added to git.bioconductor.org to continue the
pre-review process. A build report will be posted shortly. Please
fix any ERROR and WARNING in the build report before a reviewer is
assigned or provide a justification on why you feel the ERROR or
WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting
up remotes to push to git.bioconductor.org. All changes should be
pushed to git.bioconductor.org moving forward. It is required to push a
version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org
access. To manage keys and future access you may want to active your
Bioconductor Git Credentials Account

@bioc-issue-bot bioc-issue-bot added pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean and removed 1. awaiting moderation submitted and waiting clearance to access resources pre-check passed pre-review performed and ready to be added to git labels Jun 7, 2024
@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 22.04.3 LTS): SEraster_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SEraster to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@GohtaAihara
Copy link
Author

Hello,

According to the build report, the only error that my package encountered seems to be the bioc-devel mailing list subscription. I have now subscribed to the bioc-devel mailing list, and there is no changes to my package. That being said, could you please trigger a new build on your end? Or, could you please let me know how to trigger a new build without making any change?

Thank you in advance for your help.

Sincerely,

Gohta Aihara

@PeteHaitch
Copy link

@GohtaAihara It is required to push a
version bump to git.bioconductor.org to trigger a new build report
.
So increase the version number from e.g., 0.99.0 to 0.99.1 in the DESCRIPTION and then commit and push that change to git.bioconductor.org

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: e50cc79995f17dd86728180ec12ebb056aaa0ee9

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings
on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 22.04.3 LTS): SEraster_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SEraster to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot bioc-issue-bot added OK and removed ERROR labels Jun 11, 2024
@lshep lshep added 2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place and removed pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean labels Jun 21, 2024
@bioc-issue-bot
Copy link
Collaborator

A reviewer has been assigned to your package for an indepth review.
Please respond accordingly to any further comments from the reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place OK
Projects
None yet
Development

No branches or pull requests

5 participants