-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PepSetTest #3417
Comments
Hi @JmWangBio Thanks for submitting your package. We are taking a quick The DESCRIPTION file for this package is:
|
Please see initial comments: General
inst
man
vignette
|
Thanks for the comments! Please see my response below:
The interopability with SummarizedExperiment, a common class for proteomics data, is now demonstrated in the revised package.
These scripts can be used to reproduce the analysis shown in Wang et al (2024) Bioinformatics 40(5):btae270, as indicated in the "Code availability" section of the paper. The purpose of these scripts is now clarified in the vignette.
A package-level man page has been added.
The vignette has been renamed as suggested.
The abstract and introduction have been expanded to highlight the comparison between the peptide set test and existing Bioconductor methodologies.
An example using SummarizedExperiment, a common class for MS data, has been added to the vignette (Example 2). |
Your package has been added to git.bioconductor.org to continue the IMPORTANT: Please read this documentation for setting Bioconductor utilized your github ssh-keys for git.bioconductor.org |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. On one or more platforms, the build results were: "ERROR". Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Received a valid push on git.bioconductor.org; starting a build for commit id: b87a84a97fc0e9faa7578d274f22eb7169b1fb9c |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. Congratulations! The package built without errors or warnings Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
A reviewer has been assigned to your package for an indepth review. |
Hi @JmWangBio Thank you for your submission. Best regards, PepSetTest #3417The main data representations in the package are matrices and data.frames. DESCRIPTION
NAMESPACE
vignette
R
|
Received a valid push on git.bioconductor.org; starting a build for commit id: fdcabdf16b464e087f676c842d3546f6df3033d7 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. Congratulations! The package built without errors or warnings Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Hi Marcel (@LiNk-NY ), We appreciate your detailed comments and have updated our package following your suggestions. Please see our response below:
Our package has three major workflows: the competitive peptide set test workflow, the self-contained workflow, and the aggregation-based limma workflow. Following your suggestion, we have made all three workflows compatible with the
The comment argument has been removed.
All text in the vignette has been wrapped to 80 character width.
We have included an
Example 3 has been removed to improve readability.
We have replaced
We have removed
We have fixed this line of code by renaming the Please let us know if you have any additional questions or comments. |
Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
I understand that by submitting my package to Bioconductor,
the package source and all review commentary are visible to the
general public.
I have read the Bioconductor Package Submission
instructions. My package is consistent with the Bioconductor
Package Guidelines.
I understand Bioconductor Package Naming Policy and acknowledge
Bioconductor may retain use of package name.
I understand that a minimum requirement for package acceptance
is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
Passing these checks does not result in automatic acceptance. The
package will then undergo a formal review and recommendations for
acceptance regarding other Bioconductor standards will be addressed.
My package addresses statistical or bioinformatic issues related
to the analysis and comprehension of high throughput genomic data.
I am committed to the long-term maintenance of my package. This
includes monitoring the support site for issues that users may
have, subscribing to the bioc-devel mailing list to stay aware
of developments in the Bioconductor community, responding promptly
to requests for updates from the Core team in response to changes in
R or underlying software.
I am familiar with the Bioconductor code of conduct and
agree to abide by it.
I am familiar with the essential aspects of Bioconductor software
management, including:
months, for bug fixes.
(optionally via GitHub).
For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.
The text was updated successfully, but these errors were encountered: