Should C/C++/C# variables be red

[Binaryify]

Should C/C++/C# variables be red?
Some people think those should be red but other don't like red

[MalcolmMielle]

It should be consistent with other languages, so I'm voting for red :)

[tristan957]

It should follow what the Atom upstream does in my opinion, although I am not sure how much this theme currently strays from upstream.

[w-xy]

It seems to be gray in my Atom:

and I'm voting for not red. It's such an uncomfortable feeling when your company's source codes have a lot of variables and all of them are red.

[MalcolmMielle]

It's not red because atom doesn't have semantic highlighting. It's a nice property of vscode (namely its lsp) that we loose by not coloring the variables.

I also think it's a lot of red but we loose more by having everything white since other elements are white.

It's possible to paint the variables to white by changing a setting in vscode though, if it's really problematic. I'll post an example soon if you want (I use a similar trick to differentiate attributes and variable colors).

Would it be possible for one-dark to provide the color of variable as a setting? The extension would have a sensible default value, and it could be changed by the user?

[Fry98]

Agreed with @MalcolmMielle. I probably wouldn't even mind having white variables in general but it should be consistent between all languages. I'm not a fan of setting a different color for C/C++/C# only.

[GenhaoLi]

All variables painted red might look kind of harsh.

Also I think function parameters, global variables and local variables should be distinct and easily recognized.

edit: why not refer to One Dark Theme on Jetbrains marketplace?

[MalcolmMielle]

I agree that everything red is kind of similar to everything white; it defeats the purpose of the semantic highlighting.
+1 of for the JetBrains marketplace version: it has red for attributes, white for variables, and yellow for argument from what I see in the screenshot.

---

In my personal settings, I use:

"editor.semanticTokenColorCustomizations": {
    "[One Dark Pro]": {
        "rules": {
            "variable.readonly:python": "#D19A66", 
            "property:python": "#9D527C", 
            "property": "#9D527C",
        },
    },
},

It changes attributes to a deeper shade of red to make them distinguishable.

[MoonChasing]

Since I used OneDark, the variable has become coral color, and I am used to this setting.

After the variable was set to white last time, the white color made me think that vscode had crashed, and its semantics could not be parsed, so it was not rendered. And my first instinct is not that the theme is deliberately set to white.

After setting it to other colors, such as white, for access to the structure, a.mem, a is a variable, it is white, but mem is rendered in coral color, which is very awkward.

[MoonChasing]

Adding an option may be a good choice.

[Fry98]

Yeah, I first tried reinstalling the C++ extension and VS Code itself before it even occured to me it might be caused by the theme.

[MoonChasing]

Yeah, I first tried reinstalling the C++ extension and VS Code itself before it even occured to me it might be caused by the theme.

Yeah，I even mentioned an issue of vscode. XD