Skip to content
This repository has been archived by the owner on Nov 8, 2023. It is now read-only.

Add new methods in different header directories #31

Open
Bhupesh-V opened this issue Feb 16, 2019 · 24 comments · May be fixed by #642, #649, #654, #656 or #681
Open

Add new methods in different header directories #31

Bhupesh-V opened this issue Feb 16, 2019 · 24 comments · May be fixed by #642, #649, #654, #656 or #681
Labels
beginner-friendly Beginner friendly issues good first issue Good for newcomers

Comments

@Bhupesh-V
Copy link
Owner

Bhupesh-V commented Feb 16, 2019

This is for first-time-contributors :
Add functions which belong to a particular header file in its corresponding .md file inside the header folder.
For example
std::sort belongs to algorithm header file, so make a new file sort.md inside the algorithm directory while maintaining the CONTIBUTING guidelines and formats.

See todo.txt file in different header directory to see which of the methods have not been implemented yet.

@Bhupesh-V Bhupesh-V added good first issue Good for newcomers beginner-friendly Beginner friendly issues labels Feb 17, 2019
@Bhupesh-V Bhupesh-V pinned this issue Feb 17, 2019
@willdarnell
Copy link

are you saying you want the sort in sort.md moved to algorithm.md?

This was referenced May 28, 2019
@Bhupesh-V Bhupesh-V changed the title Add new functions in different .md files Add new functions in different header directories Jun 9, 2019
@dantedallag
Copy link

Is this issue solved? If not, I could try to do it.

@Bhupesh-V
Copy link
Owner Author

@dantedallag this issue always remains open to help contributors .

@Bhupesh-V Bhupesh-V changed the title Add new functions in different header directories Add new methods in different header directories Jul 11, 2019
@HarshitNITT
Copy link

Can I contribute to this issue?

@Bhupesh-V
Copy link
Owner Author

Bhupesh-V commented Sep 15, 2019

Can I contribute to this issue?

Yes you can, just see the unimplemented functions in the README.md files inside different directories

@ghost
Copy link

ghost commented Sep 26, 2019

Hi, I am new to open source in general, and I would like to contribute as a beginner.
I have a few doubts:

  1. How can I differentiate which functions are unimplemented in the README.md file?
  2. I also want to make sure if the process of contributing that I understand is right or not: At the time of writing this, the pop_back() function is not yet implemented yet. So is this what I do - I write a sample code that implements this function (by following the coding conventions of course), and this code will reside in snippet/vector. And I also make a .md file in vector directory (outside snippet) which explains the code. Is there anything that I am missing? If yes, please tell me so that I begin.

@Bhupesh-V
Copy link
Owner Author

@saisriram2710 you are right

@agrawalsajal02
Copy link

Can i contribute to this issue ?

@agrawalsajal02
Copy link

submitted a pull request 257

@sakibmahmud
Copy link

Hi, I want to contribute to this issue. Where do i start?

@satcasm
Copy link

satcasm commented Oct 21, 2019

can i contribute to this issue??

This was referenced Oct 25, 2019
UberschallSamsara added a commit to UberschallSamsara/30-seconds-of-cpp that referenced this issue Nov 1, 2019
Bhupesh-V added a commit that referenced this issue Nov 12, 2019
Add is_heap.md for upstream repo issue #31
@marcinky
Copy link

marcinky commented May 31, 2020

Hello! I would like to contribute to this issue. I have reviewed the CONTRIBUTING.md, looked at the Projects, and referenced the Kanban for each directory type. I would like to work on "pop_back" under Vector. If successful, this will be my very first Open Source contribution :)
Thank you @Bhupesh-V for making this opportunity available. So far, the instructions have been very complete and helpful.

@Bhupesh-V
Copy link
Owner Author

Hello! I would like to contribute to this issue. I have reviewed the CONTRIBUTING.md, looked at the Projects, and referenced the Kanban for each directory type. I would like to work on "pop_back" under Vector. If successful, this will be my very first Open Source contribution :)
Thank you @Bhupesh-V for making this opportunity available. So far, the instructions have been very complete and helpful.

@marcinky looks like pop_back is already implemented and only crend is available to contribute.
Don't worry just head over to specific directories like list where pop_back has not been implemented yet (see ✔️ and ❌ marks)
Go ahead and implement it and welcome to opensource 🤗

@marcinky
Copy link

Ok will do @Bhupesh-V - thank you! I'll take another look.

@marcinky marcinky mentioned this issue Jun 5, 2020
@dbejanishvili
Copy link
Contributor

Should I create a new issue before starting to work on code or should I just go ahead and open a pull request?

@athulsasi
Copy link
Contributor

Hi Bhupesh Varshney,
I would like to contribute to this issue.

I've locally created .md file with an example code for the new 'contains' in the unordered_map for C++20.
I've followed your coding guideline and also tested my code. I can create a pull request for review.

Could you please allow me write access to create a PR? Thank you for your help in advance.

@akankshasonkar17
Copy link

Hi Bhupesh Varshney,
I just made my first PR for unordered_map 's at function . Please check it out . :)

#579

@Bhupesh-V
Copy link
Owner Author

Hi Bhupesh Varshney,
I would like to contribute to this issue.

I've locally created .md file with an example code for the new 'contains' in the unordered_map for C++20.
I've followed your coding guideline and also tested my code. I can create a pull request for review.

Could you please allow me write access to create a PR? Thank you for your help in advance.

Hi @athulsasi you don't need any write access to the repo.
Everything is listed in CONTRIBUTING guidelines on how & what to contribute.

@Aokison
Copy link

Aokison commented Jun 5, 2021

Hello @Bhupesh-V. I am completely new to open source and would like to contribute to this project, specifically the crend function in the set directory. I really appreciate the opportunity provided for newcomers like me.

@adarshcode
Copy link

Hi @Bhupesh-V. Can I still contribute to this issue?

@powellsr powellsr linked a pull request Oct 10, 2021 that will close this issue
3 tasks
@varunbgit varunbgit linked a pull request Dec 15, 2021 that will close this issue
3 tasks
@varunbgit
Copy link

@Bhupesh-V I have created a PR please review and suggest changes.
#649

@aririsu aririsu linked a pull request Jan 28, 2022 that will close this issue
3 tasks
@aaryahjolia aaryahjolia linked a pull request Jan 30, 2022 that will close this issue
@deepanshu2810
Copy link

@Bhupesh-V I would like to work on this one .

@Anshul-9923
Copy link

Hi @Bhupesh-V Can I contribute to this issue a function to unordered_map?

@Aanya9693
Copy link

@Bhupesh-V,Hey! I would like to contribute to this, please assign this to me.

@Arsivnet Arsivnet linked a pull request Apr 29, 2023 that will close this issue
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.