Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error in flatbuffers/stl_emulation with new GCC version #818

Closed
ltoenning opened this issue May 16, 2024 · 3 comments
Closed

Compile error in flatbuffers/stl_emulation with new GCC version #818

ltoenning opened this issue May 16, 2024 · 3 comments

Comments

@ltoenning
Copy link

Describe the bug:
When compiling master with GCC 14.1.1, I am getting the following error message:

[...]/BehaviorTree.CPP/include/behaviortree_cpp/flatbuffers/stl_emulation.h:549:12: error: assignment of read-only member ‘flatbuffers::span<T, Extent>::count_’
  549 |     count_ = other.count_;
      |     ~~~~~~~^~~~~~~~~~~~

This was fixed in flatbuffers with google/flatbuffers#7227. It seems that the new GCC version somehow detects this error now as well.

This also affects the v3.8 branch.

How to Reproduce:

Compile BehaviorTree.CPP with GCC 14.1.1

@facontidavide
Copy link
Collaborator

I am going toi remove entirely flatbuffers from the public API.

This means deprecating the old FileLogger in favor of FileLogger2, that is much simpler and supported by Groot2.

In terms of version 3.8, I will not mainatin it anymore. If you want to submit a PR for that, I will be happy to review it.

@ltoenning
Copy link
Author

In terms of version 3.8, I will not mainatin it anymore. If you want to submit a PR for that, I will be happy to review it.

Would you prefer to completely update flatbuffers or only cherry-pick this specific change for the 3.8 branch?

@facontidavide
Copy link
Collaborator

Better to reduce the amount of changes, since I don't want to support it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants