-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haltTree doesn't effectively halt tickWhileRunning #686
Comments
It may make more sense to make |
I agree and, funny coincidence, I was thinking about that this morning. But of course, since But I should cover this case! About returning FAILED... that is another problem, since FAILING and HALTING are two different concepts. |
Yes a new |
I see your point but... not gonna happen. A new status would mean rewriting ALL the control nodes and decorators |
Yeah I understand is a pretty major API change, and that is why I originally suggested FAILED instead, but I also get your point that it is not each node that failed, (and can imagine could induce nasty side effects), so that status is only really relevant for the root node |
haltTree
resets the tree status toIDLE
which then in thetickRoot
only breaks out of the inner loop, which is then restarted by the outer loopThe text was updated successfully, but these errors were encountered: