Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: use null in Position class variables to differentiate (un)available values #1287

Open
4 tasks done
georgetian3 opened this issue Mar 11, 2024 · 1 comment
Assignees
Labels
P2 Important issues not at the top of the work list. refactor Issues marked with refactor should be considered when refactoring the plugin. type: enhancement New feature or request

Comments

@georgetian3
Copy link

Is there already an issue requesting this feature?

Please select affected platform(s)

  • Android
  • iOS
  • Windows

Use case

According to the comments of geolocator_platform_interface-4.2.2, the altitude, altitudeAccuracy, accuracy, heading, headingAccuracy, speed, speedAccuracy variables may not be available, in which case the value will be 0.

The problem is users cannot differentiate unavailable values from actual readings of 0's for those variables.

Proposal

Make all the above variables nullable, and use null as the value if the variable is unavailable. This is already implemented for the variable floor.

Specific requirements or considerations

No response

Additional information or context

No response

@TimHoogstrate TimHoogstrate self-assigned this Mar 12, 2024
@TimHoogstrate
Copy link
Contributor

Dear @georgetian3,

Thanks for your request. I'll label this as an enhancement and will probably implement something similar during our planned refactor.

Kind regards,

@TimHoogstrate TimHoogstrate added type: enhancement New feature or request P2 Important issues not at the top of the work list. refactor Issues marked with refactor should be considered when refactoring the plugin. labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Important issues not at the top of the work list. refactor Issues marked with refactor should be considered when refactoring the plugin. type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants