Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .NET 6 #386

Open
6 of 7 tasks
markuspalme opened this issue Sep 13, 2022 · 12 comments
Open
6 of 7 tasks

Support for .NET 6 #386

markuspalme opened this issue Sep 13, 2022 · 12 comments

Comments

@markuspalme
Copy link

馃殌 Feature Requests

The library currently targets Xamarin.iOS but not net6-ios/net6-android. The new TFMs are the future and using this library in new projects is currently not possible.

To address my own very short-term needs I have created a port of the iOS part of this library to .NET 6:
https://github.com/markuspalme/LottieNet6/

Platforms affected (mark all that apply)

  • 馃摫 iOS
  • 馃 Android
  • 馃弫 WPF
  • 馃寧 UWP
  • 馃崕 MacOS
  • 馃摵 tvOS
  • 馃悞 MAUI
@FreakyAli
Copy link

+1

@evgenyvalavin
Copy link

It is not currently possible to use Lottie on net6-ios due to breaking changes in net6-ios: "All code must be recompiled to support .NET 6. Existing assemblies (such as NuGets built for the old TargetFrameworkIdentifier xamarinios10) won鈥檛 work and won鈥檛 be supported. Non-xamarin specific assets for net4.x, netstandard, netcoreapp, net5.0+, etc. will work fine however." - Link
Any plans on rebuilding on .NET 6?

@markuspalme
Copy link
Author

@evgenyvalavin I have forked the library and ported it to net6-ios:
https://www.nuget.org/packages/Lottie.iOS

But of course an update of this excellent library would be better than a fork long-term.

@evgenyvalavin
Copy link

@markuspalme thanks! I already use the NuGet package.

Let's hope together this library will be updated 馃槃

@FreakyAli
Copy link

@markuspalme @evgenyvalavin My understanding of this is that this library will be obsolete and won't be updated to .net 6 at all. Instead, there is a Skia Sharp control that is going to be the Future of Lottie Animations in most .Net environments https://mono.github.io/SkiaSharp.Extended/api/ui-maui/sklottieview.html, I mean obviously, that's not on par with BaseFlow's version but that's the best we have ATM.

@Pluxury
Copy link

Pluxury commented Oct 10, 2022

@FreakyAli How can I use sklottieview in xamarin.native apps ?
I think this is not possible and we should wait for the update of this package anyway.

@FreakyAli
Copy link

@Pluxury You are right for now this seems to be the case

@AdamDiament
Copy link

AdamDiament commented Oct 26, 2022

Does anyone have an android .net6 port for this?

@petro2050
Copy link

@martijn00 what is the current plan for this?

@martijn00
Copy link
Member

I'm more than happy to accept a PR to fix this and release a new version. I've already done some work but can't get iOS to work.

@IeuanWalker
Copy link

@martijn00 where is the work you already started and do you remember what problems you were having on iOS?

@AdamDiament
Copy link

AdamDiament commented Jul 26, 2023

@martijn00 where is the work you already started and do you remember what problems you were having on iOS?

@IeuanWalker this is the in progress PR. I'm not aware of the specific iOS issues #379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants