Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks! #16

Open
BradleyShaner opened this issue Feb 25, 2018 · 1 comment
Open

Thanks! #16

BradleyShaner opened this issue Feb 25, 2018 · 1 comment

Comments

@BradleyShaner
Copy link

Thanks for this. I haven't really explored NodeJS at all, but I gave this a try on a whim because it was one of only a couple available -- and it seems to work great. I've only used it for ~10 minutes so far, but I'm impressed. I'm already seeing a slight improvement in hashrates, but I'll keep an eye on it over the next few days.

As I'd never used NodeJS before, I looked into compiling it and finally came upon "pkg". I wanted to avoid having to install NodeJS, but I'm glad I did it anyway. I ended up compiled zecproxy into an exe and it works great. I think it would help a lot of people out if you made one available.

I had to do some research, but I made my first NodeJS changes (ever!) under Miner.prototype.onData, to clean up the output from my rigs (which still send their wallet address.workername):

var split = obj.params[0].split(".");
if (split.length > 0) {
	this.name = split[1];
} else {
	this.name = obj.params[0];
}

Also, you confirmed a theory I had about proxifying pool connections to multiple miners -- no need to split up the work amongst them, just let them all work on the same thing and send in the results. I think I'll give this a try on some other crypto in the future.

It's not much, but I sent a small ethereum donation your way! Partly for the program, partly for making me jump into NodeJS, and partly for confirming my theory above. 👍

@BScrk
Copy link
Owner

BScrk commented Mar 12, 2018

Tanks, will think about that. Thanks for your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants