Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in SENet_Keras.py #19

Open
yao-ying opened this issue Aug 4, 2019 · 1 comment
Open

error in SENet_Keras.py #19

yao-ying opened this issue Aug 4, 2019 · 1 comment

Comments

@yao-ying
Copy link

yao-ying commented Aug 4, 2019

Hi Wei Li. Thanks for sharing this great code! I learn a lot from it.
I found two error in SENet_Keras.py:
1, in line 77, you use y = add_common_layer(y). add_common_layer include BN and relu. from the office code https://github.com/hujie-frank/SENet. We can see at the end of resnet block, it is just BN. And you use a relu before the se-block. It's not intuitive. So in line 77. y = BatchNormalization(momentum=0.9, epsilon=1e-5)(y).
2, in line 48, you define the global variable inplanes. But you change the value of inplances in residual_layer. So you should define the global variable inplanes in residual_layer(line 89). You can visualize the current model structure. In each shortcut branch,there is a conv+bn.
Thanks again for sharing!

@yao-ying yao-ying changed the title wrong in senet error in SENet_Keras.py Aug 4, 2019
@BIGBALLON
Copy link
Owner

@yao-ying thanks for your issue.
There are some errors in these codes since I have no more time to double check.
I hope you create a PR if you can.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants