Refreshing Node.js supported versions #786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the supported node versions to match the [current list](https://learn.microsoft.com/en-gb/azure/azure-functions/functions-reference-node?tabs=javascript%2Cwindows%2Cazure-cli&pivots=nodejs-model-v4#supported-versions), including previews.
aaronpowell
requested review from
manekinekko,
v1212,
cjk7989 and
IvanJobs
as code owners
Open
|
Oh right, tests probably need updating too 😅 |
|
I'm not sure how to fix the failing test. The test that fails is this one here and it fails because it "thinks" we have v3 of the core tools installed but we need v4 (since v3 didn't support Node18 but now v3 does). The problem is that we now have some overlaps in the version support (v3 and v4 both support Node 18 and Node 20), resulting in it not being able to tell what to install. Probably need an overhaul of that test but I'm not sure what it should look like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the supported node versions to match the current list, including previews.
Fixes #756