Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter wording of "Deploy Self-Host Integration Runtimes" #210

Open
mboswell opened this issue Nov 15, 2021 · 7 comments
Open

Alter wording of "Deploy Self-Host Integration Runtimes" #210

mboswell opened this issue Nov 15, 2021 · 7 comments
Assignees
@marvinbuss
Labels
backlog Backlog item feature Feature Requests
Milestone
v1.3.0

Comments

@mboswell
Copy link
Contributor

mboswell commented Nov 15, 2021 •
edited

In the one click deployment of a Data Landing Zone, the wording of "Deploy Self-Host Integration Runtimes" needs to be clearer that these SHIR are for Purview. Suggestion would be to change wording to "Deploy Self-Host Integration Runtimes for Purview"

DLZ-SHIR
@mboswell mboswell added the feature Feature Requests label Nov 15, 2021
@marvinbuss
Copy link
Collaborator

marvinbuss commented Nov 16, 2021 •
edited

Thanks @mboswell for submitting this. But the button here is for the user to decide whether a SHIR for Purview AND Data Factory should be deployed. Not just Purview. What would be your suggestion under these circumstances?

@mboswell
Copy link
Contributor Author

mboswell commented Nov 16, 2021 via email

@marvinbuss marvinbuss linked a pull request Nov 17, 2021 that will close this issue
Updated Portal UI based on Feedback #211
Merged
@marvinbuss marvinbuss mentioned this issue Nov 17, 2021
Merged
@marvinbuss
Copy link
Collaborator

marvinbuss commented Nov 17, 2021 •
edited

Hi @mboswell,
Have you seen this:
image

image

Any feedback? Thank you!

@mboswell
Copy link
Contributor Author

The help bubble is a good start but please can we put this into the text of "Deploy Self-hosted Integration Runtimes" to say "Deploy Self-hosted Integration Runtimes for Data Factory and Purview". The help text then explains that two VMSS sets will be created.

@marvinbuss
Copy link
Collaborator

But they are not both created. The second one cannot be created without the user providing the Key for the Purview SHIR Instance. Therefore, this change would be misleading for users.

This was referenced Nov 18, 2021
Merged
Merged
@marvinbuss marvinbuss reopened this Nov 18, 2021
@marvinbuss marvinbuss added this to the v1.2.0 milestone Nov 18, 2021
@marvinbuss marvinbuss added the committed Committed item label Nov 18, 2021
@marvinbuss
Copy link
Collaborator

marvinbuss commented Nov 18, 2021 •
edited

Sorry, this was by mistake, because I linked the wrong issue to the other PRs, but I reopened the issue earlier already.

@mboswell
Copy link
Contributor Author

This is what we are looking for...

  • SHIRs in the shared integration resource group which is linked the data factory there.
  • SHIR which are in the metadata resource group which are linked to Purview.

Hence breaking this out into two options as customer won't always have both ADF and Purview. Some might only have Purview and others only Data Factory.

SHIR-Purview-ADF

@marvinbuss marvinbuss removed a link to a pull request Nov 23, 2021
Updated Portal UI based on Feedback #211
Merged
@marvinbuss marvinbuss added backlog Backlog item and removed committed Committed item labels Nov 26, 2021
@marvinbuss marvinbuss modified the milestones: v1.2.0, v1.3.0 Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinbuss marvinbuss

Labels
backlog Backlog item feature Feature Requests
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
2 participants
@mboswell @marvinbuss