Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_root_directory_client() method for azure.storage.filedatalake.FileSystemClient class #35596

Closed
Lackshu opened this issue May 13, 2024 · 4 comments
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Data Lake issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)

Comments

@Lackshu
Copy link

Lackshu commented May 13, 2024

The current method to operate on the root directory is _get_root_directory_client() which is a protected method. It works fine when I try to operate on the ACL of the root directory. However it's not ideal to use a protected method of the class.

Please implement a public method so that we have a safer way to work with the root folder. The get_directory_client method did not work when I tried supplying in the root folder as a parameter.

If it's possible to leverage the get_directory_client method to operate on the root directory, please provide an example. Thanks.

I'm using the class library to apply ACLs to root directory and also provisioning ACLs for specific folders and propagating to the descendants.

image

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 13, 2024
@xiangyan99 xiangyan99 added Data Lake Service Attention This issue is responsible by Azure service team. and removed needs-triage This is a new issue that needs to be triaged to the appropriate team. labels May 13, 2024
@github-actions github-actions bot added the needs-team-attention This issue needs attention from Azure service team or SDK team label May 13, 2024
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @sumantmehtams.

@jalauzon-msft jalauzon-msft added the Storage Storage Service (Queues, Blobs, Files) label May 13, 2024
@jalauzon-msft
Copy link
Member

Hi @Lackshu, you should be able to just call get_directory_client('/') to get the root directory client. That's all the private method does anyway.

https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_file_system_client.py#L964

@jalauzon-msft jalauzon-msft added the issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. label May 14, 2024
@github-actions github-actions bot removed the needs-team-attention This issue needs attention from Azure service team or SDK team label May 14, 2024
Copy link

Hi @Lackshu. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text "/unresolve" to remove the "issue-addressed" label and continue the conversation.

Copy link

Hi @Lackshu, since you haven’t asked that we /unresolve the issue, we’ll close this out. If you believe further discussion is needed, please add a comment /unresolve to reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Data Lake issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

4 participants