Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Re-enable role assignment and definition tests in playback #35557

Open
mccoyp opened this issue May 8, 2024 · 0 comments
Open

[Key Vault] Re-enable role assignment and definition tests in playback #35557

mccoyp opened this issue May 8, 2024 · 0 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-proxy Anything relating to test-proxy requests or issues.
Milestone

Comments

@mccoyp
Copy link
Member

mccoyp commented May 8, 2024

As part of #35425, test_role_definitions and test_role_assignment tests were marked as live-only. The tests began failing in playback after recording with the latest test proxy version because the randomly-generated UUIDs used for role resources weren't being sanitized as expected in new recordings.

Instead of using sanitizers to record these UUIDs as some-uuid, we could instead use the variables API to store random UUIDs in recordings. However, the fact that tests are no longer able to sanitize in the same way they used to is unexpected and should be looked into.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. test-proxy Anything relating to test-proxy requests or issues. labels May 8, 2024
@mccoyp mccoyp added this to the 2024-06 milestone May 8, 2024
@mccoyp mccoyp self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-proxy Anything relating to test-proxy requests or issues.
Projects
Status: Todo
Development

No branches or pull requests

1 participant