fix move to next page in paged response #5625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gearama
requested review from
LarryOsterman,
antkmsft and
ahsonkhan
as code owners
ahsonkhan
reviewed
May 15, 2024
antkmsft
reviewed
May 16, 2024
|
FWIW, here is what code our current codegen would generate for pageable:
I didn't find a private constructor there, but the codegen is essentially doing the same by doing this: ListPagedResponse response{};
response.m_client = std::make_shared<PageableClient>(*this);
response.m_options = options;I am not proposing that you necessarily should remove the constructor, but I am more making an argument for the construction being private. |
antkmsft
reviewed
May 20, 2024
antkmsft
approved these changes
May 21, 2024
There was a problem hiding this comment.
I don't know if there is someone knowledgeable who is supposed to ok this PR, and I do not know if you resolved the other feedback from other team members in this PR, and if they are happy, but the part that I more or less understand and commented on, looks good now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5617
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.