Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CURLCode error to the non-obsoleted value within the CurlConnection ctor. #5545

Merged
merged 2 commits into from
May 16, 2024
Merged

Update CURLCode error to the non-obsoleted value within the CurlConnection ctor. #5545

merged 2 commits into from
May 16, 2024

Conversation

ahsonkhan
Copy link
Member

Fixes #5538

First introduced here: #3923

@ahsonkhan ahsonkhan self-assigned this Apr 17, 2024
antkmsft
antkmsft approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@antkmsft antkmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change, let's merge it!
Just curious, how did you discover this?

@ahsonkhan ahsonkhan enabled auto-merge (squash) May 16, 2024 17:16
@ahsonkhan ahsonkhan merged commit 6b5a8d1 into main May 16, 2024
41 checks passed
@ahsonkhan ahsonkhan deleted the ahsonkhan-patch-2 branch May 16, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gearama gearama gearama left review comments

@LarryOsterman LarryOsterman LarryOsterman approved these changes

@antkmsft antkmsft antkmsft approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

Assignees

@ahsonkhan ahsonkhan

Labels
Azure.Core
Projects
None yet
Milestone
No milestone
4 participants
@ahsonkhan @LarryOsterman @antkmsft @gearama