Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional logging to _az_RETURN_IF_* #2608

Open
2 tasks done
CIPop opened this issue Jul 18, 2023 · 0 comments
Open
2 tasks done

Add optional logging to _az_RETURN_IF_* #2608

CIPop opened this issue Jul 18, 2023 · 0 comments
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@CIPop
Copy link
Member

CIPop commented Jul 18, 2023

Is your feature request related to a problem? Please describe.
I'm always frustrated when I can't figure out which exact _az_RETURN_IF_FAILED returned from my SDK function. (for example, in _az_iot_provisioning_client_payload_registration_state_parse())

Describe the solution you'd like
A clear and concise description of which line of code failed should exist in the logs: _az_RETURN_IF_FAILED(az_json_reader_next_token(jr)); in az_iot_provisioning_client.c:322

This functionality should be optional as it does increase the binary size substantially.

Additional context
Add any other context or screenshots about the feature request here.

Information Checklist
Please make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@github-actions github-actions bot added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jul 18, 2023
@RickWinter RickWinter added feature-request This issue requires a new behavior in the product in order be resolved. Client This issue points to a problem in the data-plane of the library. Azure.Core and removed needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RickWinter @CIPop