Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cognitive Services - Azure AI Services] API Review #29078

Open
azure-sdk opened this issue May 11, 2024 · 2 comments
Open

[Cognitive Services - Azure AI Services] API Review #29078

azure-sdk opened this issue May 11, 2024 · 2 comments
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.

Comments

@azure-sdk
Copy link
Collaborator

New API Review meeting has been requested.

Service Name: Cognitive Services - Azure AI Services
Review Created By: Dapeng Li
Review Date: 05/30/2024 04:00 PM PT
Release Plan:
PR:
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description: Video dubbing API to translate video from source locale to target locale.

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@azure-sdk azure-sdk added the API Review Scoping This is an issue that will track work on a specific set of API changes. label May 11, 2024
@azure-sdk
Copy link
Collaborator Author

Meeting updated by Dapeng Li

Service Name: Cognitive Services - Azure AI Services
Review Created By: Dapeng Li
Review Date: 05/30/2024 04:00 PM PT
Release Plan:
PR:
Hero Scenarios Link: here
Core Concepts Doc Link: Not Provided

Description: Video dubbing API to translate video from source locale to target locale.
Latest:
https://github.com/Azure/azure-rest-api-specs-pr/pull/18399

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@mikekistler
Copy link
Member

Notes from API Review meeting 5/30/24

  • For long-running delete, does GET still work while delete is running? What about create with same name?
    • we want to avoid "ghosts". Resource should show as available until delete completes
    • Or make the delete synchronous with clean up handled silently in the background
  • Consider cost of storage
  • Please consider moving the definition to TypeSpec
  • What happens if the user does a PUT for an id that already exists?
    • Same input, return a 201, and not same input returns an error
  • What happens when the source content at the URL changes ?
    • Might need to capture ETag from source URL and fail
  • PUT is naturally idempotent
  • Consider not supporting anything but managed identity auth
  • Create of translation also creates the first iteration -- that's a bit odd
    • But it avoids needing two calls to create first iteration
    • Also subsequent iterations are cheaper
  • What happens if I try to create a new iteration when the last one is still running? Error
  • LastCompletedIteration -> LastSucceededIteration
  • How does the billing work when the initial translation failed?

Please convert to TypeSpec, in the process address whatever issues above that you can, and then schedule another meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.
Projects
Status: Triage
Development

No branches or pull requests

2 participants