Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeSpecRequirement] How to handle multiple matching suppressions? #29003

Closed
mikeharder opened this issue May 7, 2024 · 1 comment
Closed
Assignees

Comments

@mikeharder
Copy link
Member

Currently we just use the first returned:

return $suppressions ? $suppressions[0] : $null;

But perhaps we should do something more if multiple match? Show all reasons? Throw an error?

@mikeharder mikeharder self-assigned this May 7, 2024
@mikeharder
Copy link
Member Author

First returned seems fine to me and works well enough with inheritance

@mikeharder mikeharder closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant