Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suppressions.yaml] Add "paths" property as sibling of "path" #29000

Closed
mikeharder opened this issue May 7, 2024 · 0 comments · Fixed by #29152
Closed

[suppressions.yaml] Add "paths" property as sibling of "path" #29000

mikeharder opened this issue May 7, 2024 · 0 comments · Fixed by #29152
Assignees

Comments

@mikeharder
Copy link
Member

Summary

Add paths array to simplify multi-version suppressions:

- tool: TypeSpecRequirement
  paths:
  - data-plane/Azure.Contoso.WidgetManager/preview/2022-11-01-preview/**/*.json
  - data-plane/Azure.Contoso.WidgetManager/preview/2023-11-01-preview/**/*.json
  - data-plane/Azure.Contoso.WidgetManager/preview/2024-11-01-preview/**/*.json
  reason: Same reason for all versions

This is equivalent and would also be an allowed alternative:

- tool: TypeSpecRequirement
  path: data-plane/Azure.Contoso.WidgetManager/preview/2022-11-01-preview/**/*.json
  reason: Same reason for all versions

- tool: TypeSpecRequirement
  path: data-plane/Azure.Contoso.WidgetManager/preview/2023-11-01-preview/**/*.json
  reason: Same reason for all versions

- tool: TypeSpecRequirement
  path: data-plane/Azure.Contoso.WidgetManager/preview/2024-11-01-preview/**/*.json
  reason: Same reason for all versions

Open Issues

  • How to require either path or paths in zod validation library?
  • What if both path and paths specified?
    • Add path to array
    • Add path to array AND warn
    • Error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant