Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPG][Diff] properties of SystemData is marked as readonly #2553

Open
msyyc opened this issue Apr 29, 2024 · 3 comments
Open

[MPG][Diff] properties of SystemData is marked as readonly #2553

msyyc opened this issue Apr 29, 2024 · 3 comments
Assignees
Labels
discussion An area of design currently under discussion and open to team and community feedback. MPG Impact

Comments

@msyyc
Copy link
Member

msyyc commented Apr 29, 2024

image

@msyyc msyyc added the discussion An area of design currently under discussion and open to team and community feedback. label Apr 29, 2024
@msyyc msyyc self-assigned this Apr 29, 2024
@msyyc
Copy link
Member Author

msyyc commented Apr 29, 2024

In swagger, SystemData is marked as "readonly" while its properties not, so SDK users can still set value for its properties. But typespec mark each property of its value as "readonly" so SDK users can't set value anymore. Although it is breaking, in view of that SystemData is usually only for deserialization, the difference shall not influence SDK users.

@allenjzhang
Copy link
Member

@ArthurMa1978 , do we still need to keep this issue open?

@pshao25
Copy link
Member

pshao25 commented May 30, 2024

@mikekistler if the readonly flag is mark in a normal object, should it propagate to its properties? e.g.

 "arbitraryObject": {
      "type": "object",
      "readOnly": true,
      "properties": {
        "aproperty": {
          "type": "string",
          "description": "The identity that created the resource."
        }
    }
}

Is aproperty readonly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion An area of design currently under discussion and open to team and community feedback. MPG Impact
Projects
None yet
Development

No branches or pull requests

4 participants