Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flags for Hub/Spoke resources #153

Open
JinLee794 opened this issue May 22, 2023 · 2 comments
Open

Add feature flags for Hub/Spoke resources #153

JinLee794 opened this issue May 22, 2023 · 2 comments
Labels

Comments

@JinLee794
Copy link
Contributor

JinLee794 commented May 22, 2023

Customers have use-cases that may involve bringing their own resources (for example, an existing hub configuration)

Would like to refactor the bicep/terraform templates to accommodate for optional infrastructure resources being created and give the user set number of options on types of existing resources they can bring in.

@JinLee794
Copy link
Contributor Author

  • bicep template: jumpbox vm should be named to be more descriptive instead of (vm-<app_name>-<env>) as well as the self-hosted agent (instead of just github-<env>)

@thomas-tran
Copy link

Could we add the flag whether or not hub is required in the deployment? Customer may only need the spoke vnet and did not want to connect to any hub. Or at least, create a hub placeholder with/without firewall or bastion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants