Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挕 Feature Request - Descriptive module for creating security groups and mapping them to the custom roles through the roleAssignments module #389

Open
reduards opened this issue Nov 18, 2022 · 1 comment
Labels
Area: RBAC enhancement New feature or request long-term We will do it, but will take a longer amount of time due to complexity/priorities Upstream Dependency

Comments

@reduards
Copy link

reduards commented Nov 18, 2022

Describe the solution you'd like

I would like to see a more descriptive way of creating security groups or mapping existing security groups to the customer roles and the right scope. We currently have a module for role assignment but no recommended path to utlize it in the intial deployment.

  1. Create module or sub module (leverage by orchestration) to create security groups

  2. Have an deployment example at roleAssignment module where these groups get mapped to corresponding custom role (NetOps for example) at a/the recommended scope.

Additional context

If you believe that this is a good idea, I am more than willing to help with this work.

EDIT: Just realised that creating Azure AD security groups with bicep is not supported. However, maybe we can leave a snippet with how to do it with PowerShell (New-AzureADGroup) similiar to how we show them how to retrieve object ID of an existing security group/spn/managed identity.

Best Regards,
Rasmus

@reduards reduards added the enhancement New feature or request label Nov 18, 2022
@ghost ghost added the Needs: Triage 馃攳 Needs triaging by the team label Nov 18, 2022
@jtracey93
Copy link
Contributor

Hey @reduards,

As you have noticed creating AAD objects with Bicep is not yet supported. However, soon it hopefully will be.

Therefore I think we will place this one on long term hold until we see the AAD functionality come for Bicep.

Thanks

Jack

@jtracey93 jtracey93 added Area: RBAC Upstream Dependency long-term We will do it, but will take a longer amount of time due to complexity/priorities and removed Needs: Triage 馃攳 Needs triaging by the team labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: RBAC enhancement New feature or request long-term We will do it, but will take a longer amount of time due to complexity/priorities Upstream Dependency
Development

No branches or pull requests

2 participants