Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Customer Usage Attribution for partners #265

Open
richeney opened this issue Jun 17, 2022 · 6 comments
Open

Enable Customer Usage Attribution for partners #265

richeney opened this issue Jun 17, 2022 · 6 comments
Assignees
Labels
Area: Non-Resource Specific things like tags, location etc. enhancement New feature or request long-term We will do it, but will take a longer amount of time due to complexity/priorities

Comments

@richeney
Copy link

richeney commented Jun 17, 2022

The CUA mechanism is being used to allow tracking of the various modules and for Microsoft to provide better support.

However, Customer Usage Attribution is one of the mechanisms used to recognise partner attached ACR. It isn't the preferred mechanism - CSP and PAL are more robust - but is still valid and the repo should enable its use.

I suggest that the repo introduces a consistently named parameter, e.g. CUA_GUID, to all modules so that a partner specified GUID can filter through the modules. The parameter value would be set to the GUID generated and registered by the partner.

@richeney richeney added the enhancement New feature or request label Jun 17, 2022
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Jun 17, 2022
@jtracey93 jtracey93 self-assigned this Jun 17, 2022
@jtracey93 jtracey93 added Needs: Author Feedback Awaiting feedback from the issue/PR author Area: Non-Resource Specific things like tags, location etc. and removed Needs: Triage 🔍 Needs triaging by the team labels Jun 17, 2022
@jtracey93
Copy link
Contributor

Hey @richeney,

Thanks for raising this. This needs some consideration as it would technically break our own telemetry if we allowed the CUA ID to be set via a parameter, today its a variable, that partners could change if they wanted to today once they've forked/cloned the repo.

I agree that CSP and PAL are the better ways for partner to attach themselves to ACR.

Are there any active requests for this from partners (feel free to ping me on Teams to keep it confidential 👍)? This will help us understand priority for this work.

Potential Idea

Make the telemetry module a loop that merges the ALZ-Bicep CUA ID with an input parameter version in a concat and then loop over the combined array.

That way both PIID deployments could occur and live together.

Would you want the opt out of telemetry option to apply to the partner one also @richeney?

@richeney
Copy link
Author

To be clear, CUA is a mechanism intended for use by partners.

I don't think it supports multiple GUIDs as suggested by the loop idea. It just adds pid-GUID to the agent header and then uses the correlationId to determine which resources should be linked to the MPN ID via that pre-registered GUID.

@ghost ghost added Needs: Attention 👋 Needs attention from the maintainers and removed Needs: Author Feedback Awaiting feedback from the issue/PR author labels Jun 17, 2022
@jtracey93
Copy link
Contributor

Update:

Myself and @richeney are syncing internally on this

@jtracey93 jtracey93 added long-term We will do it, but will take a longer amount of time due to complexity/priorities Needs: Triage 🔍 Needs triaging by the team and removed Needs: Attention 👋 Needs attention from the maintainers labels Jun 17, 2022
@jtracey93
Copy link
Contributor

@richeney did we need to pick this one backup?

@jtracey93 jtracey93 added Needs: Author Feedback Awaiting feedback from the issue/PR author and removed Needs: Triage 🔍 Needs triaging by the team labels Sep 6, 2022
@richeney
Copy link
Author

richeney commented Sep 7, 2022

Yep, I think support for Customer Usage Attribution needs to be added. I understand that CUA is being used to track impact, but it is there as a partner attach ACR mechanism and partners should be able to use it here. That is analogous to the azurerm Terraform provider where Hashicorp use it by default to get some visibility on usage, but it is always available to partner (or to be switched off) even if that has an impact on what Hashicorp can see.

Note that there is a new partner program and partner score for this FY which has added focus on partner ACR attach, so we have an opportunity here to add support and avoid any unnecessary friction.

I suggest CUA in Bicep need to support both of the following formats:

  • pid-<guid>-partnercenter (Marketplace - this is the format generated in Partner Center after publishing offers)
  • pid-<guid> (Other use cases - original format, created manually and registered)

For reference, I had a recent PR in the Terraform azurerm provider which was pulled into the v3.21.0 release. Issue 17403 / Pull 17441.

Adding @mormond, who's the Marketplace guru in the team!

@ghost ghost added Needs: Attention 👋 Needs attention from the maintainers and removed Needs: Author Feedback Awaiting feedback from the issue/PR author labels Sep 7, 2022
@jtracey93
Copy link
Contributor

Ado sync

@jtracey93 jtracey93 assigned jtracey93 and unassigned jtracey93 Sep 7, 2022
@jtracey93 jtracey93 removed the Needs: Attention 👋 Needs attention from the maintainers label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Non-Resource Specific things like tags, location etc. enhancement New feature or request long-term We will do it, but will take a longer amount of time due to complexity/priorities
Development

No branches or pull requests

2 participants