Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'validate' parameter to use during releases #643

Open
pjlewisuk opened this issue Aug 16, 2023 · 4 comments
Open

Add 'validate' parameter to use during releases #643

pjlewisuk opened this issue Aug 16, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request Keep Open stale An issue that hasn't had a lot of love recently

Comments

@pjlewisuk
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Add a new parameter to be used during deployments and releases which can be used to set parameters or transform text within the helper during a release, e.g. changing az deployment group create to az deployment group create during the TestWebApp / Validation workflow.

Describe the solution you'd like
Add a parameter that can be passed into the workflow to toggle behaviour for deployment testing. See https://github.com/Azure/AKS-Construction/pull/642/files for how to pass the parameter into PlayWright.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@pjlewisuk pjlewisuk added the enhancement New feature or request label Aug 16, 2023
@samaea
Copy link
Contributor

samaea commented Aug 24, 2023

Is this still an issue or resolved as part of our previous conversations?

@pjlewisuk
Copy link
Contributor Author

It came up in discussions during the last release, so yeah, I think it's still needed.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Oct 1, 2023
@pjlewisuk pjlewisuk removed the stale An issue that hasn't had a lot of love recently label Oct 1, 2023
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Nov 1, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2023
@pjlewisuk pjlewisuk reopened this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Keep Open stale An issue that hasn't had a lot of love recently
Projects
None yet
Development

No branches or pull requests

2 participants