Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor for v1.0 #313

Open
4 of 8 tasks
Gordonby opened this issue Jun 29, 2022 · 4 comments
Open
4 of 8 tasks

Refactor for v1.0 #313

Gordonby opened this issue Jun 29, 2022 · 4 comments
Assignees
@samaea @MattLeach25
Labels
enhancement New feature or request Keep Open

Comments

@Gordonby
Copy link
Collaborator

Gordonby commented Jun 29, 2022 •
edited

Capturing small changes required before we take the releases to v1.0.0

Parameters / Outputs

  • Parameter naming - camelCasing of all names for consistency
  • Parameter naming - Abbreviation consistency
  • Output - Add Aks ResourceId
  • Parameter defaults, consistency between config.json and the bicep parameters.
  • Use Deployment().name as a prefix in all other deployments

Bicep file refactoring

  • Split Key Vault into its own bicep file
  • Split AppGw into its own bicep file

Other issues that need to be completed
@Gordonby Gordonby added the enhancement New feature or request label Jun 29, 2022
@Gordonby Gordonby mentioned this issue Jul 13, 2022
Merged
5 tasks
@github-actions
Copy link
Contributor

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Jul 30, 2022
@Gordonby Gordonby removed the stale An issue that hasn't had a lot of love recently label Jul 31, 2022
@Gordonby Gordonby mentioned this issue Aug 12, 2022
Merged
5 tasks
@github-actions
Copy link
Contributor

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Aug 31, 2022
@Gordonby Gordonby added Keep Open and removed stale An issue that hasn't had a lot of love recently labels Aug 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Dec 5, 2022
@Gordonby Gordonby removed the stale An issue that hasn't had a lot of love recently label Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Jan 5, 2023
@Gordonby Gordonby removed the stale An issue that hasn't had a lot of love recently label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samaea samaea

@MattLeach25 MattLeach25

Labels
enhancement New feature or request Keep Open
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gordonby @samaea @MattLeach25