-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy.sh script should not change default az cli settings #44
Comments
Also, in the Create Azure Spring Apps service instance section of the README, it says to configure global defaults: az configure --defaults \
group=${RESOURCE_GROUP} \
location=${REGION} \
spring=${SPRING_APPS_SERVICE} Personally, I think this is a bad idea and worse in the I prefer using a local scope for defaults with configure this file az configure --scope local --defaults \
group=${RESOURCE_GROUP} \
location=${REGION} \
spring=${SPRING_APPS_SERVICE} However, this is more useful for interactive use. For scripting, as @asaikali suggested above, it's probably better to just pass in args |
Currently the ./deploy.sh script makes a call to the function
It is surprising that the script changes the defaults settings for the
az
cli, it is better if the script uses the passed in args-r
,-s
,-g
without changing defaultsacme-fitness-store/azure/deploy.sh
Line 30 in dd52c7f
The text was updated successfully, but these errors were encountered: