Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept different folder for Global Parameters than "factory" #375

Open
MartaUch opened this issue Oct 19, 2023 · 3 comments
Open

Accept different folder for Global Parameters than "factory" #375

MartaUch opened this issue Oct 19, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@MartaUch
Copy link

Hi Kamil,
I would have a question regarding current solution of global parameters deployment.

  • We assume that we have one json file under "factory" folder. If we have more it takes the first found one.
  • Later we can use configuration files under particual path.

Current situation in our platfrom.
We deploy only pipelines, datasets and dataflows automatically so far. We would like to use incremental deployment and deploy global parameters. Idea was to keep one json file under factory folder called "deep-ENV-adf-we.json" and later use configuration files that updates values for each enviornment (but we are not deploying to DEV, so dev congifuration file is not so important).

However, we have our dev instance connected to repository. It means that everytime someone create global parameter on dev on the feature branch, file reflecting global parameters is added automatically to "factory" folder.
It complicates the implementation for us, because then we have 2 files, and only the first one is taken (currently it would be this one from dev). Dev however is not correctly maintained. We can have there much less global parameters than on INT and PRD where deployment team was creating them manually on demand.

In such a case I would like to separate folder which keeps information about dev and folder which keeps this template json file.

Would that be possible that global parameters could be deployed from different folder than "factory"?
Or if not possible, would that be possible to extend solution and allow for more than one json file under factory folder?

Maybe you would have another suggestion.

Thank you in advance!
Marta

@MartaUch
Copy link
Author

I decided just to take dev json file as a template and later update with config files as suppose to :) everything is fine, but I think it would be still great if we could define which exactly json file should be taken for global parameters from factory folder. I know that sometimes even more ADF instances can be connected to one repository and use the same source files - then we have two json files under factory folder (but that’s just hypothetical) :)

@NowinskiK
Copy link
Member

I think it's a edge case scenario and not very useful for many. However, because it's possible (as you said) having more than 1 files in factory folder - I'll consider to make it configurable. BTW, did you check whether is it possible now selecting (by including) such file using selective deployment and provide name like "factory.file"?

@NowinskiK NowinskiK self-assigned this Oct 28, 2023
@NowinskiK NowinskiK added the enhancement New feature or request label Oct 28, 2023
@MartaUch
Copy link
Author

MartaUch commented Oct 28, 2023

Thank you for taking that into the consideration :)
Currently we start with this assumption that only one file is allowed to use incremental deployment and it works as suppose to, so thank you for this great tool once again :)


Did you check whether is it possible now selecting (by including) such file using selective deployment and provide name like "factory.file"?
Yes, I was checking that already when I was raising similar issue in the past: #344. The goal was to have three json files that would represent environments (without configuration files and with incremental deployment). But as a result, adftools_deployment_state was never deployed (for other environments) because during the step ""STEP: Updating (incremental) deployment state...", only first file found under factory folder is taken. Deployment of global parameters only (without incremental deployment) would work.

Example (but this time with config file):
image
image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants