Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextBox text selection/copy doesn't work #376

Open
1 task done
LyleRolleman-plst opened this issue May 1, 2024 · 6 comments
Open
1 task done

TextBox text selection/copy doesn't work #376

LyleRolleman-plst opened this issue May 1, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@LyleRolleman-plst
Copy link

Usage Information

3.6.0

Description

Trying to select text within a TextBox doesn't work properly on Android/iOS. Tapping and holding brings up a Cut, Copy, Paste and Select All context menu, but cut and copy remain disabled with no ability to select the text, except Select All which then hides the context menu, making it pretty useless.

This isn't a problem when using the default FluentTheme so something in here seems to be overriding and breaking the behaviour

Reproduction Steps

Attempt to select TextBox with text using usual tap/hold/drag. Observe doesn't select, with aforementioned broken context menu. Drag handles from base Avalonia/FluentTheme do not appear

Expected Behavior

I should be able to select text in a TextBox to copy

Actual Behavior

See description

Regression?

No response

Known Workarounds

No response

Anything else?

No response

Could you help with a pull-request?

No

Is there an existing issue for this?

  • I have searched the existing issues
@LyleRolleman-plst LyleRolleman-plst added the bug Something isn't working label May 1, 2024
@SKProCH
Copy link
Collaborator

SKProCH commented May 1, 2024

I'll take a look.

@SKProCH
Copy link
Collaborator

SKProCH commented May 11, 2024

Seems like Material textbox behaves as default Fluent one. Here is the demo:

video_2024-05-11_20-00-03.mp4

I've also doesn't see any drag handles from avalonia. May be I'm missing something? Can you share the sample app with proper avalonia's TextBox behavior?

@LyleRolleman-plst
Copy link
Author

Material

Fluent

I've attached two screenshots that show the difference between Material and Fluent (the theme being the only difference between the projects)

I've also attached the test project.
SelectionTest.zip

@SKProCH
Copy link
Collaborator

SKProCH commented May 13, 2024

Oh, probably the 11.1.0-beta2 is the reason. I'll take a look.

@SKProCH
Copy link
Collaborator

SKProCH commented May 13, 2024

Seems like this is exclusive 11.1.0-beta feature and wasn't accessible within 11.0.*.
So, probably I've should start a new branch to target new avalonia version.
Related Avalonia's commit is eb5fdd2a3d776ea7e3309d68c69ec008c45ff468

@LyleRolleman-plst
Copy link
Author

That would certainly be welcome as we do need the beta branch features and I get the impression the beta will be moving into general release very soon

@SKProCH SKProCH added enhancement New feature or request and removed bug Something isn't working waiting for feedback labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants